Codecov Report

Merging #4466 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4466      +/-   ##
==========================================
+ Coverage   83.13%   83.15%   +0.01%     
==========================================
  Files         268      268              
  Lines       53915    53912       -3     
==========================================
+ Hits        44820    44828       +8     
+ Misses       9095     9084      -11     

I think this is a good solution. I would just add a warning when using something from Numeric section and no numeric data is present on the input. And same for categorical. Probably it would be nice to let the user know her selection will not have any effect.

I would just add a warning when using something from Numeric section and no numeric data is present on the input.

I guess I would prefer not to do it.

We have a warning of a similar kind in Test & Score, where the widget warns the user if there is Test data on input, but the user didn't choose to use it. But there the user showed an intention and the "wrong" setting in the widget affects the result.

In Continuize, the setting would probably just be left like it was before (hence no intention) and, most importantly, the setting has no effect on output in this case.

By adding this warning -- would we warn the user to not use this setting when there is no numeric data? Ehm, no, it doesn't hurt. We would essentially be warning the user that he showed an intention to normalize numeric features but fed no numeric features to the widget. If this was the case, he would notice missing numeric features anyway. :)

I would avoid warnings that do not require user's attention, otherwise we make users imune to warnings (think "your connection is not secure" in browsers...)

Ok.